Skip to content

chore: address commit comments #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

chore: address commit comments #5202

merged 1 commit into from
Feb 13, 2025

Conversation

saurabhraghuvanshii
Copy link
Contributor

Resolves #5146

Description

What is the purpose of this pull request?

This pull request:

  • Address commit comments

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@saurabhraghuvanshii
chore: address CC
a82604a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 12, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/exponential/logpdf $\color{green}281/281$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}281/281$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@saurabhraghuvanshii saurabhraghuvanshii changed the title refractor: Address commit comments chore: address commit comments Feb 12, 2025
@saurabhraghuvanshii saurabhraghuvanshii marked this pull request as draft February 12, 2025 15:42
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 12, 2025
@saurabhraghuvanshii saurabhraghuvanshii marked this pull request as ready for review February 12, 2025 15:42
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 12, 2025
Planeshifter
Planeshifter approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Planeshifter Planeshifter changed the title chore: address commit comments chore: address commit comments Feb 13, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 13, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 13, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: address commit comments

PR-URL: https://github.com/stdlib-js/stdlib/pull/5202
Closes: https://github.com/stdlib-js/stdlib/issues/5146

Co-authored-by: saurabhraghuvanshii <saurabhsraghuvanshi@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit f64e693 into stdlib-js:develop Feb 13, 2025
78 of 79 checks passed
@saurabhraghuvanshii saurabhraghuvanshii deleted the exponential-logpdf branch February 18, 2025 15:25
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@saurabhraghuvanshii @ShabiShett07
chore: address commit comments
6c776ee 
PR-URL: stdlib-js#5202
Closes: stdlib-js#5146

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit a94091c)
3 participants
@saurabhraghuvanshii @stdlib-bot @Planeshifter