Skip to content

chore: refactor according to commit comments #5098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2025
Merged

chore: refactor according to commit comments #5098

merged 2 commits into from
Feb 8, 2025

Conversation

saurabhraghuvanshii
Copy link
Contributor

Resolves #5091.

Description

What is the purpose of this pull request?

This pull request:

  • refractor acc to CC

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@saurabhraghuvanshii
chore: refractor acc to cc
41a413b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 7, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 7, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/beta/logpdf $\color{green}386/386$
$\color{green}+100.00\%$ 		$\color{green}47/47$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}386/386$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Planeshifter
Planeshifter reviewed Feb 8, 2025
View reviewed changes
@Planeshifter
chore: replace periods with commas
8ddf86d 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Planeshifter Planeshifter changed the title chore: refractor acc to cc beta/logpdf chore: refactor according to commit comments Feb 8, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 8, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 8, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: refactor according to commit comments

PR-URL: https://github.com/stdlib-js/stdlib/pull/5098
Closes: https://github.com/stdlib-js/stdlib/issues/5091

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: saurabhraghuvanshii <saurabhsraghuvanshi@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 556ec54 into stdlib-js:develop Feb 8, 2025
28 checks passed
@saurabhraghuvanshii saurabhraghuvanshii deleted the beta-logpdf branch February 8, 2025 15:34
saurabhraghuvanshii added a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
@saurabhraghuvanshii @Planeshifter
chore: refactor according to commit comments
ccd0006 
PR-URL: stdlib-js#5098
Closes: stdlib-js#5091

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@saurabhraghuvanshii @Planeshifter @ShabiShett07
chore: refactor according to commit comments
8d5c9b2 
PR-URL: stdlib-js#5098
Closes: stdlib-js#5091

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit b1f7e5c)
3 participants
@saurabhraghuvanshii @stdlib-bot @Planeshifter