Skip to content

bench: refactor random number generation in stats/base/dists/weibull #5011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

bench: refactor random number generation in stats/base/dists/weibull #5011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9d5ce3
feat: refactor random number generation stats/base/dists/weibull
ShabiShett07 Feb 1, 2025
181e204
fix: solved errors
ShabiShett07 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions lib/node_modules/@stdlib/stats/base/dists/weibull/cdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -32,17 +33,25 @@ var cdf = require( './../lib' );

bench( pkg, function benchmark( b ) {
var lambda;
var len;
var k;
var x;
var y;
var i;

len = 100;
x = new Float64Array( len );
lambda = new Float64Array( len );
k = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( EPS, 100.0 );
lambda[ i ] = uniform( EPS, 100.0 );
k[ i ] = uniform( EPS, 100.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*100.0 ) + EPS;
lambda = ( randu()*100.0 ) + EPS;
k = ( randu()*100.0 ) + EPS;
y = cdf( x, k, lambda );
y = cdf( x[ i % len ], k[ i % len ], lambda[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -58,6 +67,7 @@ bench( pkg, function benchmark( b ) {
bench( pkg+':factory', function benchmark( b ) {
var lambda;
var mycdf;
var len;
var k;
var x;
var y;
Expand All @@ -66,11 +76,16 @@ bench( pkg+':factory', function benchmark( b ) {
lambda = 3.14;
k = 2.25;
mycdf = cdf.factory( k, lambda );
len = 100;

x = new Float64Array( len );
Comment on lines +79 to +81
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
len = 100;
x = new Float64Array( len );
len = 100;
x = new Float64Array( len );

No space between initializations

for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( EPS, 100.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*100.0 ) + EPS;
y = mycdf( x );
y = mycdf( x[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
16 changes: 12 additions & 4 deletions lib/node_modules/@stdlib/stats/base/dists/weibull/entropy/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -32,15 +33,22 @@ var entropy = require( './../lib' );

bench( pkg, function benchmark( b ) {
var lambda;
var len;
var k;
var y;
var i;

len = 100;
lambda = new Float64Array( len );
k = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
k[ i ] = uniform( EPS, 10.0 );
lambda[ i ] = uniform( EPS, 10.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
k = ( randu()*10.0 ) + EPS;
lambda = ( randu()*10.0 ) + EPS;
y = entropy( k, lambda );
y = entropy( k[ i % len ], lambda[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
16 changes: 12 additions & 4 deletions lib/node_modules/@stdlib/stats/base/dists/weibull/kurtosis/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var kurtosis = require( './../lib' );
Expand All @@ -31,15 +32,22 @@ var kurtosis = require( './../lib' );

bench( pkg, function benchmark( b ) {
var lambda;
var len;
var k;
var y;
var i;

len = 100;
lambda = new Float64Array( len );
k = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
k[ i ] = uniform( 1.0, 10.0);
lambda[ i ] = uniform( 1.0, 10.0);
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
k = ( randu()*10.0 ) + 1.0;
lambda = ( randu()*10.0 ) + 1.0;
y = kurtosis( k, lambda );
y = kurtosis( k[ i % len ], lambda[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
30 changes: 22 additions & 8 deletions lib/node_modules/@stdlib/stats/base/dists/weibull/logcdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -32,17 +33,25 @@ var logcdf = require( './../lib' );

bench( pkg, function benchmark( b ) {
var lambda;
var len;
var k;
var x;
var y;
var i;

len = 100;
x = new Float64Array( len );
lambda = new Float64Array( len );
k = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( EPS, 100.0);
lambda[ i ] = uniform( EPS, 100.0);
k[ i ] = uniform( EPS, 100.0);
}
b.tic();

for ( i = 0; i < b.iterations; i++ ) {
Comment on lines 51 to 53
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
b.tic();
for ( i = 0; i < b.iterations; i++ ) {
b.tic();
for ( i = 0; i < b.iterations; i++ ) {

x = ( randu()*100.0 ) + EPS;
lambda = ( randu()*100.0 ) + EPS;
k = ( randu()*100.0 ) + EPS;
y = logcdf( x, k, lambda );
y = logcdf( x[ i % len ], k[ i % len ], lambda[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -58,6 +67,7 @@ bench( pkg, function benchmark( b ) {
bench( pkg+':factory', function benchmark( b ) {
var mylogcdf;
var lambda;
var len;
var k;
var x;
var y;
Expand All @@ -66,11 +76,15 @@ bench( pkg+':factory', function benchmark( b ) {
lambda = 3.14;
k = 2.25;
mylogcdf = logcdf.factory( k, lambda );

len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( EPS, 100.0 );
}
b.tic();

for ( i = 0; i < b.iterations; i++ ) {
Comment on lines 84 to 86
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
b.tic();
for ( i = 0; i < b.iterations; i++ ) {
b.tic();
for ( i = 0; i < b.iterations; i++ ) {

x = ( randu()*100.0 ) + EPS;
y = mylogcdf( x );
y = mylogcdf( x[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
30 changes: 22 additions & 8 deletions lib/node_modules/@stdlib/stats/base/dists/weibull/logpdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -32,17 +33,25 @@ var logpdf = require( './../lib' );

bench( pkg, function benchmark( b ) {
var lambda;
var len;
var k;
var x;
var y;
var i;

len = 100;
x = new Float64Array( len );
lambda = new Float64Array( len );
k = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( EPS, 100.0 );
lambda[ i ] = uniform( EPS, 100.0 );
k[ i ] = uniform( EPS, 100.0 );
}
b.tic();

for ( i = 0; i < b.iterations; i++ ) {
Comment on lines 51 to 53
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
b.tic();
for ( i = 0; i < b.iterations; i++ ) {
b.tic();
for ( i = 0; i < b.iterations; i++ ) {

This change is required throughout the PR.

x = ( randu()*100.0 ) + EPS;
lambda = ( randu()*100.0 ) + EPS;
k = ( randu()*100.0 ) + EPS;
y = logpdf( x, k, lambda );
y = logpdf( x[ i % len ], k[ i % len ], lambda[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -58,6 +67,7 @@ bench( pkg, function benchmark( b ) {
bench( pkg+':factory', function benchmark( b ) {
var mylogpdf;
var lambda;
var len;
var k;
var x;
var y;
Expand All @@ -66,11 +76,15 @@ bench( pkg+':factory', function benchmark( b ) {
lambda = 3.14;
k = 2.25;
mylogpdf = logpdf.factory( k, lambda );

len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( EPS, 100.0 );
}
b.tic();

for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*100.0 ) + EPS;
y = mylogpdf( x );
y = mylogpdf( x[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
16 changes: 12 additions & 4 deletions lib/node_modules/@stdlib/stats/base/dists/weibull/mean/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -32,15 +33,22 @@ var mean = require( './../lib' );

bench( pkg, function benchmark( b ) {
var lambda;
var len;
var k;
var y;
var i;

len = 100;
k = new Float64Array( len );
lambda = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
k[ i ] = uniform( EPS, 10.0 );
lambda[ i ] = uniform( EPS, 10.0 );
}
b.tic();

for ( i = 0; i < b.iterations; i++ ) {
k = ( randu()*10.0 ) + EPS;
lambda = ( randu()*10.0 ) + EPS;
y = mean( k, lambda );
y = mean( k[ i % len ], lambda[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
16 changes: 12 additions & 4 deletions lib/node_modules/@stdlib/stats/base/dists/weibull/median/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -32,15 +33,22 @@ var median = require( './../lib' );

bench( pkg, function benchmark( b ) {
var lambda;
var len;
var k;
var y;
var i;

len = 100;
k = new Float64Array( len );
lambda = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
k[ i ] = uniform( EPS, 10.0 );
lambda[ i ] = uniform( EPS, 10.0 );
}
b.tic();

for ( i = 0; i < b.iterations; i++ ) {
k = ( randu()*10.0 ) + EPS;
lambda = ( randu()*10.0 ) + EPS;
y = median( k, lambda );
y = median( k[ i % len ], lambda[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
Loading