Skip to content

bench: refactor random number generation in stats/base/dists/geometric #4931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

anandkaranubc
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for stats/base/dists/geometric.
  • Replaces randu() with uniform() for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@kgryte kgryte added the bot: Merge Pull request needing the latest project code be merged in. label Feb 8, 2025
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. Statistics Issue or pull request related to statistical functionality. and removed bot: Merge Pull request needing the latest project code be merged in. labels Feb 8, 2025
@kgryte kgryte added the Benchmarks Pull requests adding or improving benchmarks for measuring performance. label Feb 8, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/geometric/cdf $\color{green}223/223$
$\color{green}+100.00\%$
$\color{green}25/25$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}223/223$
$\color{green}+100.00\%$
stats/base/dists/geometric/ctor $\color{green}469/469$
$\color{green}+100.00\%$
$\color{green}28/28$
$\color{green}+100.00\%$
$\color{green}17/17$
$\color{green}+100.00\%$
$\color{green}469/469$
$\color{green}+100.00\%$
stats/base/dists/geometric/entropy $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$
stats/base/dists/geometric/kurtosis $\color{green}107/107$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}107/107$
$\color{green}+100.00\%$
stats/base/dists/geometric/logcdf $\color{green}227/227$
$\color{green}+100.00\%$
$\color{green}25/25$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}227/227$
$\color{green}+100.00\%$
stats/base/dists/geometric/logpmf $\color{green}221/221$
$\color{green}+100.00\%$
$\color{green}22/22$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}221/221$
$\color{green}+100.00\%$
stats/base/dists/geometric/mean $\color{green}165/165$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}165/165$
$\color{green}+100.00\%$
stats/base/dists/geometric/median $\color{green}109/109$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}109/109$
$\color{green}+100.00\%$
stats/base/dists/geometric/mgf $\color{red}212/216$
$\color{green}+98.15\%$
$\color{red}15/17$
$\color{green}+88.24\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{red}212/216$
$\color{green}+98.15\%$
stats/base/dists/geometric/mode $\color{green}107/107$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}107/107$
$\color{green}+100.00\%$
stats/base/dists/geometric/pmf $\color{green}292/292$
$\color{green}+100.00\%$
$\color{green}23/23$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}292/292$
$\color{green}+100.00\%$
stats/base/dists/geometric/quantile $\color{green}234/234$
$\color{green}+100.00\%$
$\color{green}25/25$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}234/234$
$\color{green}+100.00\%$
stats/base/dists/geometric/skewness $\color{green}166/166$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}166/166$
$\color{green}+100.00\%$
stats/base/dists/geometric/stdev $\color{green}108/108$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}108/108$
$\color{green}+100.00\%$
stats/base/dists/geometric/variance $\color{green}107/107$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}107/107$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the bot: In Progress Pull request is currently awaiting automation. label Feb 8, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit bce4dac into stdlib-js:develop Feb 8, 2025
12 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
PR-URL: stdlib-js#4931
Reviewed-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#4931
Reviewed-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
@anandkaranubc anandkaranubc deleted the geometric-benchmarks branch May 10, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmarks Pull requests adding or improving benchmarks for measuring performance. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants