Skip to content

feat: add C implementation for stats/base/dists/levy/entropy #4919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2025
Merged

feat: add C implementation for stats/base/dists/levy/entropy #4919

merged 4 commits into from
Apr 5, 2025

Conversation

NishchayRajput
Copy link
Contributor

Resolves #3723.

Description

What is the purpose of this pull request?

This pull request:

  • Add C implementation for @stdlib/stats/base/dists/levy/entropy

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@NishchayRajput
feat: add C implementation for @stdlib/stats/base/dists/levy/entropy
4d2120e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/stats/base/dists/levy/entropy feat: add C implementation for stats/base/dists/levy/entropy Mar 6, 2025
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Mar 6, 2025
Planeshifter
Planeshifter requested changes Mar 7, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good and close to land; left a few comments that should be addressed.

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 7, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/levy/entropy $\color{green}183/183$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}183/183$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@NishchayRajput
Copy link
Contributor Author

Looks quite good and close to land; left a few comments that should be addressed.

Thanks @Planeshifter, will ensure similar changes to be done in my other PRs if any.

@Planeshifter
Merge branch 'develop' into nishchay-base-levy-entropy
0d0654a 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
chore: remove duplicated require
bde52a0 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NishchayRajput for addressing all comments! Will merge shortly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 5, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/levy/entropy`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4919
Closes: https://github.com/stdlib-js/stdlib/issues/3723

Co-authored-by: Nishchay Rajput <121144841+NishchayRajput@users.noreply.github.com>
Co-authored-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit d623ed1 into stdlib-js:develop Apr 5, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/levy/entropy
3 participants
@NishchayRajput @stdlib-bot @Planeshifter