Skip to content

feat: add C implementation for stats/base/dists/levy/quantile #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 5, 2025
Merged

feat: add C implementation for stats/base/dists/levy/quantile #4756

merged 19 commits into from
Mar 5, 2025

Conversation

saurabhraghuvanshii
Copy link
Contributor

Resolves #3730 .

Description

What is the purpose of this pull request?

This pull request:

  • add c implementation for @stdlib/stats/base/dists/levy/quantile

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 14, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 14, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/levy/quantile $\color{green}295/295$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}295/295$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@saurabhraghuvanshii
Copy link
Contributor Author

/stdlib help

@stdlib-bot
Copy link
Contributor

@saurabhraghuvanshii, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025
@stdlib-bot
Copy link
Contributor

@saurabhraghuvanshii, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@saurabhraghuvanshii
Copy link
Contributor Author

/stdlib help

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 14, 2025
@stdlib-bot
Copy link
Contributor

@saurabhraghuvanshii, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 14, 2025
@saurabhraghuvanshii
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 14, 2025
saurabhraghuvanshii
saurabhraghuvanshii commented Jan 18, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/levy/quantile/examples/c/example.c Outdated

for ( i = 0; i < 25; i++ ) {
p = random_uniform( 0.0, 10.0 );
mu = random_uniform( 0.0, 10.0 ) - 5.0;

This comment was marked as resolved.

Sign in to view

@saurabhraghuvanshii
chore: updates minor mistakes and fix tests
6f1a799 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Neerajpathak07
Copy link
Member

Neerajpathak07 commented Feb 21, 2025 •
edited
Loading

@saurabhraghuvanshii The PR is in much better shape now!!
Just update your PR tittle to:-
feat: add C implementation for stats/base/dists/levy/quantile

@saurabhraghuvanshii saurabhraghuvanshii changed the title feat: add c implementation for @stdlib/stats/base/dists/levy/quantile feat: add c implementation for stats/base/dists/levy/quantile Feb 21, 2025
@saurabhraghuvanshii saurabhraghuvanshii changed the title feat: add c implementation for stats/base/dists/levy/quantile feat: add C implementation for stats/base/dists/levy/quantile Feb 21, 2025
@saurabhraghuvanshii
Merge branch 'stdlib-js:develop' into levy-quantile
9cab688
@saurabhraghuvanshii
chore: add missing value and revert test.quantile.js
9b266f0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@saurabhraghuvanshii
Copy link
Contributor Author

done .

@saurabhraghuvanshii
chore: update test.native.js
ff6887b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@Neerajpathak07
Copy link
Member

LGTM!! Thank you soo much for the changes.
@Planeshifter Kindly take a look at this.

@saurabhraghuvanshii
Copy link
Contributor Author

@Neerajpathak07 thanks for reviewing my messing files it is hard work . Thanks again

@saurabhraghuvanshii
Copy link
Contributor Author

@kgryte @Planeshifter it is ready for merge and review by @Neerajpathak07 check it

@Planeshifter
chore: apply suggestions from code review
e0297c5 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 5, 2025
@Planeshifter
chore: fix indentation
bfb1354
@Planeshifter
chore: add missing space
fb2a9cc 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @saurabhraghuvanshii, for raising this PR and @Neerajpathak07 for review.

Looks good to me; I will land this shortly after all CI check have passed.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 5, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 5, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/levy/quantile`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4756
Closes: https://github.com/stdlib-js/stdlib/issues/3730

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Saurabh Singh <saurabhsraghuvanshi@gmail.com>
Co-authored-by: saurabhraghuvanshii <saurabhsraghuvanshi@gmail.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 2bb57c6 into stdlib-js:develop Mar 5, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neerajpathak07 Neerajpathak07 Neerajpathak07 left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/levy/quantile
4 participants
@saurabhraghuvanshii @stdlib-bot @Neerajpathak07 @Planeshifter