Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dsmeanpn #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 18, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dsmeanpn #4331

merged 15 commits into from
Jan 18, 2025

Conversation

Neerajpathak07
Copy link
Member

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dnanmeanwd
  • refactor JavaScript implementation
  • refactor examples, tests, docs and benchmarks in manifest.json

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 28, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 28, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dsmeanpn $\color{green}379/379$
$\color{green}+100.00\%$ 		$\color{green}18/18$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}379/379$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 28, 2024 20:02
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 28, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 31, 2024
@Neerajpathak07 Neerajpathak07 mentioned this pull request Dec 31, 2024
Merged
1 task
@Neerajpathak07 Neerajpathak07 mentioned this pull request Jan 4, 2025
Merged
1 task
@Neerajpathak07 Neerajpathak07 deleted the ndarray-dsmeanpn branch January 4, 2025 18:07
@Neerajpathak07 Neerajpathak07 restored the ndarray-dsmeanpn branch January 4, 2025 18:09
@Neerajpathak07 Neerajpathak07 reopened this Jan 4, 2025
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jan 18, 2025
kgryte
kgryte reviewed Jan 18, 2025
View reviewed changes
kgryte
kgryte reviewed Jan 18, 2025
View reviewed changes
@kgryte
Apply suggestions from code review
662a311 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Jan 18, 2025
@kgryte kgryte merged commit 5cfc390 into stdlib-js:develop Jan 18, 2025
42 checks passed
@Neerajpathak07 Neerajpathak07 deleted the ndarray-dsmeanpn branch January 19, 2025 05:05
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 19, 2025
@Neerajpathak07 @kgryte @saurabhraghuvanshii
feat: add C ndarray interface and refactor implementation for `stat…
09473d8 
…s/base/dsmeanpn`

PR-URL: stdlib-js#4331
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Neerajpathak07 added a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@Neerajpathak07 @kgryte
feat: add C ndarray interface and refactor implementation for `stat…
127fc57 
…s/base/dsmeanpn`

PR-URL: stdlib-js#4331
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025
@Neerajpathak07 @kgryte @Vinit-Pandit
feat: add C ndarray interface and refactor implementation for `stat…
cee9c99 
…s/base/dsmeanpn`

PR-URL: stdlib-js#4331
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@Neerajpathak07 @kgryte @ShabiShett07
feat: add C ndarray interface and refactor implementation for `stat…
2222cb6 
…s/base/dsmeanpn`

PR-URL: stdlib-js#4331
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neerajpathak07 @stdlib-bot @kgryte