Skip to content

refactor: update benchmarks in stats/base to follow latest project conventions #4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2024
Merged

refactor: update benchmarks in stats/base to follow latest project conventions #4299

merged 1 commit into from
Dec 27, 2024

Conversation

aayush0325
Copy link
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • updates benchmarks in stats/base
  • adds missing @privateannotation

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aayush0325
refactor: update existing benchmarks in stats/base to follow latest p…
fab2243 
…roject conventions

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 27, 2024
@aayush0325
Copy link
Member Author

aayush0325 commented Dec 27, 2024 •
edited
Loading

i can update this after #4287, #4292 and #4293 are merged, here's the PR you requested @Planeshifter, thanks for pointing out the issues!

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dnanmax $\color{green}380/380$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}380/380$
$\color{green}+100.00\%$
stats/base/dnanmaxabs $\color{green}382/382$
$\color{green}+100.00\%$ 		$\color{green}29/29$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}382/382$
$\color{green}+100.00\%$
stats/base/dnanmin $\color{green}381/381$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}381/381$
$\color{green}+100.00\%$
stats/base/dnanminabs $\color{green}381/381$
$\color{green}+100.00\%$ 		$\color{green}29/29$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}381/381$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for following up on this, @aayush0325!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 27, 2024
@kgryte kgryte merged commit 054139f into stdlib-js:develop Dec 27, 2024
43 checks passed
Planeshifter referenced this pull request Dec 27, 2024
@aayush0325
feat: add C ndarray interface and refactor implementation for `stats/…
9f86bc6 
…base/snanmin`

PR-URL: #4292

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 1, 2025
@aayush0325 @Neerajpathak07
refactor: update benchmarks in stats/base to follow latest project …
80b3e94 
…conventions

PR-URL: stdlib-js#4299
Reviewed-by: Athan Reines <kgryte@gmail.com>
@aayush0325 aayush0325 deleted the private-fix branch January 8, 2025 19:04
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@aayush0325 @ShabiShett07
refactor: update benchmarks in stats/base to follow latest project …
bd40038 
…conventions

PR-URL: stdlib-js#4299
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aayush0325 @stdlib-bot @kgryte