Skip to content

refactor: update implementation to handle edge cases in eslint/rules/eol-open-bracket-spacing #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • add edge case tests
  • update rule implementation to handle edge case tests

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 26, 2024
@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. Tools Issue or pull request related to project tooling. labels Dec 26, 2024
@kgryte kgryte removed the Feature Issue or pull request for adding a new feature. label Dec 26, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge and then address any further edge cases in future PRs.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 26, 2024
@kgryte kgryte changed the title refactor: update implementation to handle edge cases for eslint/rules/eol-open-bracket-spacing refactor: update implementation to handle edge cases in eslint/rules/eol-open-bracket-spacing Dec 26, 2024
@kgryte kgryte merged commit 826c947 into stdlib-js:develop Dec 26, 2024
56 checks passed
@headlessNode headlessNode deleted the open-bracket-empty-obj branch December 27, 2024 05:06
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 1, 2025
…/eol-open-bracket-spacing`

PR-URL: stdlib-js#4254
Reviewed-by: Athan Reines <kgryte@gmail.com>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
…/eol-open-bracket-spacing`

PR-URL: stdlib-js#4254
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools Issue or pull request related to project tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants