Skip to content

refactor: update stats/base/dnanminabs native addon from C++ to C #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

vivekmaurya001
Copy link
Contributor

Resolves None.

Description

  • adds C addons to stats/base/dnanminabs instead of c++ addons

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 21, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 21, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dnanminabs $\color{green}433/433$
$\color{green}+100.00\%$
$\color{green}49/49$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}433/433$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 21, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Dec 22, 2024
@kgryte kgryte merged commit a0eb37f into stdlib-js:develop Dec 22, 2024
14 checks passed
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#4126
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants