Skip to content

feat: add C implementation for stats/base/dists/levy/median #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 6, 2025
Merged

feat: add C implementation for stats/base/dists/levy/median #4076

merged 14 commits into from
Mar 6, 2025

Conversation

vivekmaurya001
Copy link
Contributor

Resolves #3727.

Description

  • adds C implementation for @stdlib/stats/base/dists/levy/median along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 20, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 20, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/levy/median $\color{green}182/182$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}182/182$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 19, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 19, 2025
Planeshifter
Planeshifter reviewed Jan 19, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/levy/median/src/main.c Outdated
* // returns ~0.795
*/
double stdlib_base_dists_levy_median( const double mu, const double c ) {
double DENOM = 2.0 * stdlib_base_pow( stdlib_base_erfcinv( 0.5 ), 2.0 );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekmaurya001 We should pre-compute this constant as a static const in the outer scope since erfcinv(0.5) is constant and doesn't change with the inputs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have tried it with static const but i was getting error in that so i have maded it static double , is it ok ?

Planeshifter
Planeshifter reviewed Jan 19, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Jan 19, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Jan 19, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/levy/median/benchmark/c/benchmark.c Outdated
Comment on lines 104 to 105
mu[ i ] = random_uniform( 0.0, 100.0 ) - 50.0;
c[ i ] = random_uniform( 0.0, 20.0 ) + STDLIB_CONSTANT_FLOAT64_EPS;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mu[ i ] = random_uniform( 0.0, 100.0 ) - 50.0;
c[ i ] = random_uniform( 0.0, 20.0 ) + STDLIB_CONSTANT_FLOAT64_EPS;
mu[ i ] = random_uniform( -50.0, 50.0 );
c[ i ] = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 20.0 );

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done , one thing to ask ,can we not take c as 0 or smaller than eps

Planeshifter
Planeshifter requested changes Jan 19, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on how to optimize the source implementation and pointed out a bunch of other small issues. Should be ready to land once these are addressed.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 19, 2025
@vivekmaurya001 vivekmaurya001 marked this pull request as draft January 20, 2025 19:18
@vivekmaurya001
feat(add c implementation): add stats/base/dists/levy/median
67320dd 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: failed
---
@vivekmaurya001
feat(add c implementation): add stats/base/dists/levy/median
9f498ac 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: failed
---
@vivekmaurya001
feat(add c implementation): add stats/base/dists/levy/median
0891b40 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: failed
---
@vivekmaurya001
feat(add c implementation): add stats/base/dists/levy/median
4d766f0
@vivekmaurya001
feat(add c implementation): add stats/base/dists/levy/median
0e8064a 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: failed
---
@vivekmaurya001
feat(add c implementation): add stats/base/dists/levy/median
e2332cc 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@vivekmaurya001 vivekmaurya001 marked this pull request as ready for review January 21, 2025 12:39
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 21, 2025
@vivekmaurya001
Copy link
Contributor Author

@Planeshifter , done the changes please take a look

Planeshifter
Planeshifter reviewed Mar 6, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 6, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 6, 2025
View reviewed changes
@Planeshifter
refactor: hard-code constant instead of dynamically evaluating it
49af9bd 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 6, 2025
Planeshifter
Planeshifter approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited the source implementation in main.c, but otherwise PR looked great. Will merge shortly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 6, 2025
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Mar 6, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/levy/median`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4076
Closes: https://github.com/stdlib-js/stdlib/issues/3727

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit b790b70 into stdlib-js:develop Mar 6, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/levy/median
3 participants
@vivekmaurya001 @stdlib-bot @Planeshifter