Skip to content

feat: add C implementation for stats/base/dists/cauchy/mode #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 28, 2024

Conversation

vivekmaurya001
Copy link
Contributor

Resolves #3484.

Description

  • adds C implementation for @stdlib/stats/base/dists/cauchy/mode along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 16, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 16, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/cauchy/mode $\color{green}159/159$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}159/159$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vivekmaurya001! Left a few comments but otherwise PR should be ready to land.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 16, 2024
@vivekmaurya001
Copy link
Contributor Author

@Planeshifter tests are getting failed should i revert eps package in manifest ?

@vivekmaurya001
Copy link
Contributor Author

@Planeshifter , done the changes please take a look

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this PR shortly. Thanks for all your work, @vivekmaurya001 !

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
…k/c/benchmark.c

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 28, 2024
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Dec 28, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 28, 2024

PR Commit Message

feat: add C implementation for `stats/base/dists/cauchy/mode`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3952
Closes: https://github.com/stdlib-js/stdlib/issues/3484

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit f5f16d3 into stdlib-js:develop Dec 28, 2024
27 checks passed
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 1, 2025
PR-URL: stdlib-js#3952
Closes: stdlib-js#3484

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
PR-URL: stdlib-js#3952
Closes: stdlib-js#3484

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#3952
Closes: stdlib-js#3484

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/cauchy/mode
3 participants