Skip to content

feat: add C implementation stats/base/dists/rayleigh/pdf #3945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 17, 2024
Merged

feat: add C implementation stats/base/dists/rayleigh/pdf #3945

merged 7 commits into from
Dec 17, 2024

Conversation

Vinit-Pandit
Copy link
Contributor

Resolves #3807.

Description

What is the purpose of this pull request?

This pull request:

  • add c implementation stats/base/dists/rayleigh/pdf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 16, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 16, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/rayleigh/pdf $\color{green}295/295$
$\color{green}+100.00\%$ 		$\color{green}29/29$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}295/295$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Vinit-Pandit Vinit-Pandit marked this pull request as draft December 16, 2024 08:02
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 16, 2024
@Vinit-Pandit
fix: Update lib/node_modules/@stdlib/stats/base/dists/rayleigh/pdf/sr…
7fa747f 
…c/main.c

Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
@Vinit-Pandit Vinit-Pandit marked this pull request as ready for review December 16, 2024 13:54
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 16, 2024
@Vinit-Pandit
fix: clean up
46dc66c 
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
@Vinit-Pandit
fix: sigma instead of a
35a90d7 
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
@Vinit-Pandit
fix: add private annotation
e070666 
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
Planeshifter
Planeshifter approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MeastroZI!

There were a few minor issues in the PR but those should now be resolved. Will merge shortly after CI has passed.

@Planeshifter
chore: apply suggestions from code review
247c7d0 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 17, 2024
@Planeshifter Planeshifter changed the title feat: add c implementation stats/base/dists/rayleigh/pdf feat: add C implementation stats/base/dists/rayleigh/pdf Dec 17, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 17, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 17, 2024 •
edited by Planeshifter
Loading

PR Commit Message

feat: add C implementation `stats/base/dists/rayleigh/pdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3945
Closes: https://github.com/stdlib-js/stdlib/issues/3807

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit c0d9c76 into stdlib-js:develop Dec 17, 2024
21 checks passed
@Vinit-Pandit
Copy link
Contributor Author

Vinit-Pandit commented Dec 17, 2024 •
edited
Loading

Thank You @Planeshifter , I will be more careful from next time for this kind of issues.

sethdivyansh pushed a commit to sethdivyansh/stdlib that referenced this pull request Dec 18, 2024
@Vinit-Pandit @Planeshifter @sethdivyansh
feat: add C implementation stats/base/dists/rayleigh/pdf
334110c 
PR-URL: stdlib-js#3945
Closes: stdlib-js#3807

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
@Vinit-Pandit Vinit-Pandit deleted the stats/base/dists/rayleigh/pdf branch December 20, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/rayleigh/pdf
3 participants
@Vinit-Pandit @stdlib-bot @Planeshifter