Skip to content

bench: refactor benchmarks and update function parameter description #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

gunjjoshi
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • updates the function parameter description in the C implementation of rempio2Kernel, in math/base/special/rempio2.
  • updates benchmarks according to latest conventions.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 14, 2024
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/rempio2 $\color{red}893/907$
$\color{green}+98.46\%$
$\color{red}81/86$
$\color{green}+94.19\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{red}893/907$
$\color{green}+98.46\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for following up on this, @gunjjoshi!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Dec 14, 2024
@kgryte kgryte changed the title docs: update function parameter description and benchmarks in math/base/special/rempio2 bench: refactor benchmarks and update function parameter description Dec 14, 2024
@kgryte kgryte merged commit a851ddd into stdlib-js:develop Dec 14, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants