Skip to content

feat: add C ndarray API and refactor blas/ext/base/dsumkbn #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 14, 2024

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • add C ndarray API and refactor blas/ext/base/dsumkbn

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Dec 12, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 12, 2024

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsumkbn $\color{green}388/388$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}388/388$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Dec 12, 2024
@headlessNode
Copy link
Member Author

CI failure from a downstream test suite.

@headlessNode headlessNode marked this pull request as ready for review December 12, 2024 12:01
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 12, 2024
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 13, 2024
@headlessNode headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Dec 13, 2024
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Dec 14, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C `ndarray` API and refactor `blas/ext/base/dsumkbn`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3530

Co-authored-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@kgryte
Copy link
Member

kgryte commented Dec 14, 2024

As the CI failure is expected, I'll go ahead and merge.

@kgryte kgryte merged commit bcc704d into stdlib-js:develop Dec 14, 2024
19 of 20 checks passed
@headlessNode headlessNode deleted the dsumkbn-refactor branch December 14, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants