-
-
Notifications
You must be signed in to change notification settings - Fork 836
feat: add array/base/mskunary5d
#3207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Coverage Report
The above coverage report was generated for the changes in this PR. |
Co-authored-by: Abhijit <abhijitmraut8010@gmail.com> Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
array/base/mskunary5d
/stdlib update-copyright-years |
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
Co-authored-by: Abhijit <abhijitmraut8010@gmail.com> Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
Re: questions.
TMK: this isn't possible to do with a single index. The inputs are nested arrays which are not necessarily contiguous in memory. If we were operating on strided arrays, you could calculate a single index and use a single
For these packages, we prefer an iterative approach for performance. We do provide a separate recursive implementation (e.g., |
/stdlib lint-autofix |
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @MeastroZI, and thanks @AbhijitRaut04 for your help.
PR-URL: stdlib-js#3207 Closes: stdlib-js#3177 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com> Signed-off-by: Athan Reines <kgryte@gmail.com> Co-authored-by: Abhijit <abhijitmraut8010@gmail.com> Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>
Resolves #3177 .
Description
This pull request:
Related Issues
This pull request:
array/base/mskunary5d
#3177Questions
In the current implementation, I have used the helper function so that max depth does not exceed 5 (lint error) and minimum changes are made compared to their previous 3D version. There are still better ways to do that like:
But I am afraid to take decisions on my own by changing the way, so let me know if the implementation needs further changes.
Other
No.
Checklist
@stdlib-js/reviewers