feat: add math/base/special/gcdf
#2997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Planeshifter Ready for initial review! |
Signed-off-by: Aayush Khanna <96649223+aayush0325@users.noreply.github.com>
gunjjoshi
reviewed
Oct 10, 2024
gunjjoshi
reviewed
Oct 10, 2024
gunjjoshi
reviewed
Oct 10, 2024
gunjjoshi
reviewed
Oct 10, 2024
gunjjoshi
reviewed
Oct 10, 2024
gunjjoshi
reviewed
Oct 10, 2024
gunjjoshi
reviewed
Oct 10, 2024
gunjjoshi
reviewed
Oct 10, 2024
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
gunjjoshi
reviewed
Oct 10, 2024
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
gunjjoshi
reviewed
Oct 10, 2024
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
gunjjoshi
reviewed
Oct 10, 2024
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
gunjjoshi
reviewed
Oct 10, 2024
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
gunjjoshi
reviewed
Oct 10, 2024
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/julia/REQUIRE
Outdated
Show resolved
Hide resolved
gunjjoshi
reviewed
Oct 10, 2024
lib/node_modules/@stdlib/math/base/special/gcdf/benchmark/julia/benchmark.jl
Outdated
Show resolved
Hide resolved
kgryte
added
the
Needs Changes
kgryte
added
status: Blocked
1 task
|
@aayush0325 |
Planeshifter
removed
the
status: Blocked
|
noted, will push the cnanges soon! |
|
@Planeshifter , i've rebased the branch and made the changes but when i try to push them it looks through all the changed files (due to rebasing i think) and there's apparently a linting error in one of them so i'm not able to push my code. how to proceed here. |
|
@aayush0325 You can bypass the hook by pushing with the |
aayush0325
pushed a commit
to aayush0325/stdlib
that referenced
this pull request
Nov 11, 2024
PR-URL: stdlib-js#3059 Ref: stdlib-js#2997 Ref: stdlib-js#3055 Ref: stdlib-js#649 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
aayush0325
force-pushed
the
gcdf
branch
2 times, most recently
from
73a539a to
604ada8
Compare
|
kindly let me know if i should make any other changes @Planeshifter |
Planeshifter
approved these changes
Nov 11, 2024
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
removed
Needs Review
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
added
the
Ready To Merge
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves part of #649 .
Description
This pull request:
math/base/special/gcdfRelated Issues
This pull request:
Questions
No.
Other
Checklist
@stdlib-js/reviewers