feat: add fs/read-ndjson
#2969
Merged
feat: add fs/read-ndjson
#2969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Planeshifter ready for initial review! |
kgryte
added
Feature
kgryte
reviewed
Oct 1, 2024
kgryte
reviewed
Oct 1, 2024
kgryte
reviewed
Oct 1, 2024
lib/node_modules/@stdlib/_tools/lint/filenames/lib/extensions.json
Outdated
Show resolved
Hide resolved
|
Should I add these link as ndjson :https://ndjson.org/ in readme. md |
|
Yes, that would be preferrable. |
|
@kgryte Ready for final review |
|
@Planeshifter it has been almost 3 weeks.i am free now, can you please review my pr |
kgryte
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
This now LGTM. Thanks for your contribution, @yaswanthkosuru.
Neerajpathak07
pushed a commit
to Neerajpathak07/stdlib
that referenced
this pull request
Nov 9, 2024
PR-URL: stdlib-js#2969 Closes: stdlib-js#1074 Ref: stdlib-js#1075 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
aayush0325
pushed a commit
to aayush0325/stdlib
that referenced
this pull request
Nov 11, 2024
PR-URL: stdlib-js#2969 Closes: stdlib-js#1074 Ref: stdlib-js#1075 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1074.
Description
his RFC proposes adding a filesystem utility to read a file which is newline-delimited JSON (NDJSON).
Related Issues
#1075
This pull request:
@stdlib/fs/read-ndjson#1074Checklist
@stdlib-js/reviewers