feat: support negative strides for idamax and isamax
#2793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
added
Enhancement
Pranavchiku
commented
Aug 15, 2024
kgryte
requested changes
Aug 15, 2024
There was a problem hiding this comment.
@Pranavchiku We also need to update the ndarray.native.js bindings. We shouldn't have divergent behavior if the implementation is JS or via a native add-on. The change to ndarray.native.js is straightforward, and we need to update the tests accordingly.
Pranavchiku
changed the title
idamax and isamaxidamax and isamax
kgryte
requested changes
Aug 15, 2024
There was a problem hiding this comment.
@Pranavchiku Looks good. Only small change is that the notes in the README need to be updated. Namely,
- If `N < 1`, both functions return `-1`.
...and in the REPL text file.
|
Done, this PR can have a final review. |
gunjjoshi
pushed a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2793 Closes: stdlib-js#2792 Ref: stdlib-js#2464 Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2792. Towards #2464.
Description
This pull request enhances existing JS ndarray implementation of
blas/base/idamaxandblas/base/isamaxto support negative strides.Related Issues
NA
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers