-
-
Notifications
You must be signed in to change notification settings - Fork 834
feat: add C implementation for math/base/special/gamma-delta-ratio
#2662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gunjjoshi 1) You should be consulting the Boost GitHub repo when examining implementations: https://github.com/boostorg/math/blob/develop/include/boost/math/special_functions/gamma.hpp. 2) Using the repo, you can perform a |
In short, use the tools available to you to simplify the R&D. 🙂 |
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
lib/node_modules/@stdlib/math/base/special/gamma-delta-ratio/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gamma-delta-ratio/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/gamma-delta-ratio/src/main.c
Outdated
Show resolved
Hide resolved
@gunjjoshi instead of using the GitHub UI, in the future, I suggest cloning the Boost repo and doing the diff locally, that way you can do a diff on only the file in question. |
…rc/main.c Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
…rc/main.c Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
lib/node_modules/@stdlib/math/base/special/gamma-delta-ratio/src/main.c
Outdated
Show resolved
Hide resolved
…rc/main.c Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land this one! 🚀
PR-URL: stdlib-js#2662 Ref: stdlib-js#649 --------- Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Athan Reines <kgryte@gmail.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
Description
This pull request:
C
implementation formath/base/special/gamma-delta-ratio
.main.js
forMAX_FACTORIAL
, by importing it.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers