Skip to content

feat: add lapack/base/dlamch #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 22, 2024
Merged

feat: add lapack/base/dlamch #2568

merged 14 commits into from
Aug 22, 2024

Conversation

Pranavchiku
Copy link
Member

Description

What is the purpose of this pull request?

This pull request adds JS implementation for lapack/base/dlamch

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added the LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). label Jul 12, 2024
@Pranavchiku Pranavchiku marked this pull request as ready for review July 12, 2024 05:14
Pranavchiku
Pranavchiku commented Jul 12, 2024
View reviewed changes
Pranavchiku
Pranavchiku commented Jul 12, 2024
View reviewed changes
@Pranavchiku
chore: apply suggestions from code review
87b2ecd 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku commented Jul 16, 2024
View reviewed changes
Pranavchiku and others added 2 commits July 16, 2024 17:21
@Pranavchiku
enh: support lower case alphabets as well
f61a4db 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
chore: consequent changes
866dc08
kgryte
kgryte reviewed Jul 16, 2024
View reviewed changes
@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Needs Review A pull request which needs code review. labels Jul 22, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 22, 2024
kgryte
kgryte approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte merged commit 536f5db into stdlib-js:develop Aug 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @kgryte