Skip to content

feat: add bracketed-paste mode in the REPL #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 5, 2024
Merged

feat: add bracketed-paste mode in the REPL #2502

merged 13 commits into from
Jul 5, 2024

Conversation

Snehil-Shah
Copy link
Member

Resolves #2068

Description

What is the purpose of this pull request?

This pull request:

  • adds bracketed paste mode in the REPL
  • The default is enabled in TTY environments and is disabled back upon closing the REPL.
  • Pasted content is not executed and can be edited.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Snehil-Shah
feat: add bracketed-paste mode
643fca7 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@Snehil-Shah Snehil-Shah added Enhancement Issue or pull request for enhancing existing functionality. REPL Issue or pull request specific to the project REPL. labels Jul 3, 2024
@Snehil-Shah
refactor: move paste sequence detection to onKeypress handler
5a39fd8 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
kgryte
kgryte reviewed Jul 3, 2024
View reviewed changes
kgryte
kgryte reviewed Jul 3, 2024
View reviewed changes
@Snehil-Shah
feat: add setting to control auto disabling of bracketed-paste on exit
06b836c 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@Snehil-Shah
fix: preserve indentation of pasted content by disabling TAB completions
88d8b40 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@Snehil-Shah
style: remove extra line
12bc919 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@Snehil-Shah Snehil-Shah requested a review from kgryte July 4, 2024 19:41
kgryte
kgryte reviewed Jul 5, 2024
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
ba8cf2c 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jul 5, 2024
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2024
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
9c0c5df 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jul 5, 2024
View reviewed changes
@kgryte
Copy link
Member

kgryte commented Jul 5, 2024

Aside: this PR is quite nice, as it is a big win to be able to copy and paste multi-line content into the REPL. So thank you for working on this.

@Snehil-Shah
Copy link
Member Author

@kgryte I was thinking if it would make sense to disable auto close pairs during the pasting process? I noticed that pasting feels slow and it might also interfere if the user is not pasting syntactically correct code?

@kgryte
Copy link
Member

kgryte commented Jul 5, 2024

@Snehil-Shah That makes sense.

@kgryte
Copy link
Member

kgryte commented Jul 5, 2024

Whenever a user pastes content, what gets pasted should match verbatim the original content.

@Snehil-Shah
refactor: apply suggestions from code review
93c751c 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@Snehil-Shah
fix: ignore autoCloser when pasting
6a72b73 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@Snehil-Shah
Copy link
Member Author

@kgryte Done. Whatever the user pastes is preserved including TAB indentations.

@Snehil-Shah Snehil-Shah requested a review from kgryte July 5, 2024 09:30
@Snehil-Shah
style: keep it consistent
55e365f 
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
kgryte
kgryte reviewed Jul 5, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
acad9bf 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jul 5, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
295da0b 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jul 5, 2024
View reviewed changes
@kgryte
Apply suggestions from code review
8f8e1a4 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Snehil-Shah!

@kgryte kgryte merged commit 7ba179c into stdlib-js:develop Jul 5, 2024
7 checks passed
@Snehil-Shah Snehil-Shah mentioned this pull request Jul 5, 2024
Merged
1 task
kgryte pushed a commit that referenced this pull request Jul 5, 2024
@Snehil-Shah
test: fix failing tests in the REPL
243ab4d 
Addresses a test regression introduced in #2502.

PR-URL: #2516
Ref: #2502
Ref: 7ba179c
Reviewed-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Enhancement Issue or pull request for enhancing existing functionality. REPL Issue or pull request specific to the project REPL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add support for bracketed paste in the REPL
2 participants
@Snehil-Shah @kgryte