Skip to content

feat: add array/base/cuany #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 15, 2024
Merged

feat: add array/base/cuany #2375

merged 15 commits into from
Jun 15, 2024

Conversation

adityacodes30
Copy link
Contributor

@adityacodes30 adityacodes30 commented Jun 14, 2024

Resolves #2319

Description

What is the purpose of this pull request?

This pull request:

Adds implementation for array/base/cuany

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jun 15, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready. @adityacodes30 I had to make a number of changes, including refactoring the implementation, accounting for complex number arrays, and addressing copy-paste errors. Please make sure you go through the changes prior to working on cuevery.

@kgryte kgryte merged commit d9ef2aa into stdlib-js:develop Jun 15, 2024
8 checks passed
@adityacodes30
Copy link
Contributor Author

Thanks, I tried to make sure there weren't any copy paste errors, (think i forgot to push in my refactoring commit). Will go through the changes

@kgryte kgryte changed the title feat : add array/base/cuany feat: add array/base/cuany Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/array/base/cuany
2 participants