feat: add `blas/base/scnrm2` #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kgryte merged 29 commits into stdlib-js:develop from aman-095:scnrm2

Jun 22, 2024

Member

aman-095 commented May 27, 2024

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to find the euclidean norm of a complex single-precision floating-point vector as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/scnrm2 is proposed.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers


          feat: add BLAS Level 1 routine for scnrm2

c3aab4b

stdlib-bot added the BLAS label


          chore: apply review changes

5453d22

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/lib/ndarray.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/lib/ndarray.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/lib/ndarray.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/lib/ndarray.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/lib/scnrm2.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/benchmark/benchmark.ndarray.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/benchmark/benchmark.ndarray.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/benchmark/benchmark.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/lib/scnrm2.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/lib/scnrm2.js Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/package.json Outdated Show resolved Hide resolved

kgryte requested changes

View reviewed changes

Member

kgryte left a comment

Left an initial round of comments and requested changes. This package does not include C/Fortran implementations. Is the plan to add in a subsequent PR? The OP does not currently say.

kgryte added Feature Needs Changes labels

kgryte mentioned this pull request

feat: add blas/base/dznrm2 #2271

Merged

1 task

kgryte and others added 10 commits

June 10, 2024 23:48


          bench: ensure arrays are of intended length

9bb083a


          docs: update descriptions

e50fcda


          bench: inline expression to avoid unnecessary reassignment

4b7d1d8


          refactor: update implementation

ef90a7c


          docs: update variable type description

ee25669


          chore: apply emulation of float32 arithmetic

90bafad


          Merge branch 'stdlib-js:develop' into scnrm2

5ea715a


          feat: add C / Fortran implementation for scnrm2

0d073d4


          chore: apply review changes

35e62a7


          chore: resolve lint error

76f52c8

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/src/scnrm2_cblas.c Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/src/scnrm2.c Outdated Show resolved Hide resolved

kgryte reviewed

View reviewed changes

lib/node_modules/@stdlib/blas/base/scnrm2/manifest.json Outdated Show resolved Hide resolved

aman-095 and others added 17 commits

June 21, 2024 12:06


          chore: apply review changes

9793d8a


          Merge branch 'develop' of https://github.com/stdlib-js/stdlib into pr…

10f1444

…/aman-095/2270


          docs: fix examples

fe7b972


          docs: ensure examples are not completely trivial

90f1d59


          docs: convey input array is not mutated

99cd863


          docs: update comment

00e3745


          fix: ensure float32 emulation and add source comments

7e69dc0


          refactor: simplify implementation by using abs2f

a7e989c


          refactor: defer to ndarray implementation

42e6982


          docs: fix description

d46acc9


          refactor: update and clean-up implementation

0ec88e7


          refactor: clean-up implementation and update leading comment with cor…

4a684f6

…rect attribution


          test: remove duplicate test file

5a53655


          fix: use correct alias and update dependencies

5deb528


          docs: update copy and examples

5f09584


          test: clean-up

aa2833e


          fix: use correct macro name

3af24f4

kgryte removed the Needs Changes label

kgryte approved these changes

View reviewed changes

Member

kgryte left a comment

LGTM. Thanks for working on this, @aman-095.

Note that the various changes will need to be carried over to #2271.

kgryte merged commit c49ba29 into stdlib-js:develop

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels