Skip to content

feat: add string/base/for-each-code-point-right #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2024
Merged

feat: add string/base/for-each-code-point-right #2163

merged 4 commits into from
Apr 20, 2024

Conversation

AhmedKhaled590
Copy link
Contributor

@AhmedKhaled590 AhmedKhaled590 commented Apr 14, 2024 •
edited by kgryte
Loading

Progresses #856

Description

What is the purpose of this pull request?
Adding support for invoking a callback for each Unicode code point in a string while iterating from right to left
This pull request:

  • add @stdlib/string/base/for-each-code-point-right

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte changed the title feat: add-string-base-for-each-code-point-right feat: add string/base/for-each-code-point-right Apr 20, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Utilities Issue or pull request concerning general utilities. labels Apr 20, 2024
kgryte
kgryte approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @AhmedKhaled590!

@kgryte kgryte merged commit 91f84da into stdlib-js:develop Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedKhaled590 @kgryte