Skip to content

feat: add string/last #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

adityacodes30
Copy link
Contributor

@adityacodes30 adityacodes30 commented Apr 9, 2024

Resolves #854

Description

What is the purpose of this pull request?

This pr adds support for returning the last (visual) character(s) of a string.

This pull request:

Adds string/last

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for working on this @adityacodes30! Looks all good to me; will merge shortly.

@Planeshifter Planeshifter merged commit 22aaef5 into stdlib-js:develop Apr 9, 2024
@kgryte kgryte changed the title feat: add string/base/last feat: add string/last Apr 9, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add @stdlib/string/last
3 participants