Skip to content

fix addon of blas/ext/base/dcusumors #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

itskdhere
Copy link
Contributor

Description

What is the purpose of this pull request?

This pull request:

  • fixes the data type of sum from int64 to double in src/addon.c of blas/ext/base/dcusumors

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

https://github.com/stdlib-js/stdlib/pull/2041/files#diff-b5fcd80892477ade520b4d9b66e72c4a414a3a4e6acb1e05c9d91d15a4a3fcacL111

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 28, 2024
@Planeshifter Planeshifter added Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 28, 2024
@Planeshifter
Copy link
Member

Thanks for the fix!

@Planeshifter Planeshifter merged commit 04f59a2 into stdlib-js:develop Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants