-
-
Notifications
You must be signed in to change notification settings - Fork 835
feat: add C implementation for math/base/special/sin
#2031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aman Morghade <136126298+xaman27x@users.noreply.github.com>
NOTE: |
@stdlib/node_modules/math/base/special/sin
@stdlib/node_modules/math/base/special/sin
math/base/special/sin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing files, please refer similar PRs add those and then this can be reviewed. Also sin
implementation depends on rempio2
for which we do not have C implementation atm, so this PR is blocked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xaman27x As is, we cannot accept the changes introduced in this PR. Please ensure you study how other packages include C implementations.
E.g., don't write your own binding.gyp
file, copy it from other packages, comments and all.
You shouldn't be modifying the contents of package.json
, except for gypfile
and directories
. Use project Makefiles
, copying them from other packages.
We have project tooling for compilation. Learn that tooling.
Your addon interface does not conform to our conventions.
Your C implementation needs considerable work. sin
depends on rempio2
: https://svnweb.freebsd.org/base/release/9.3.0/lib/msun/src/s_sin.c?view=markup. Meaning, the prerequisite for adding a C implementation to sin
has not been satisfied in order to add this implementation.
Alright! I'll copy all necessary files henceforth! And since the Sin implementation requires C implementation of 'rempio2' as well, I'll work upon that first! |
Description
This pull request:
Adds native C implementation for @stdlib/math/base/special/sin
double stdlib_base_sin ( const double x );
Related Issues
Issue Tracker: #2018
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers