refactor: update blas/ext/base/dssumpw to follow current project conventions
#1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
the
BLAS
Planeshifter
changed the title
blas/ext/base/dssumpw to follow current project conventions
kgryte
added
Enhancement
kgryte
reviewed
Mar 23, 2024
| STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 5 ); | ||
| STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 2 ); | ||
| STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, Y, N, strideY, argv, 4 ); | ||
| c_saxpy( N, alpha, X, strideX, Y, strideY ); |
There was a problem hiding this comment.
This implementation is incorrect. See the addon.cpp file and update accordingly.
There was a problem hiding this comment.
Updated addon.c file as instructed. Please review. Thanks!
kgryte
added
the
Needs Changes
6 tasks
Signed-off-by: Soumajit Chatterjee <121816890+soumajit23@users.noreply.github.com>
Signed-off-by: Soumajit Chatterjee <121816890+soumajit23@users.noreply.github.com>
lib/node_modules/@stdlib/blas/ext/base/dssumpw/test/test.dssumpw.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/test/test.ndarray.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/test/test.ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/test/test.dssumpw.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/include/stdlib/blas/ext/base/dssumpw.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/lib/dssumpw.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/examples/c/Makefile
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/docs/types/test.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/benchmark/c/Makefile
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/benchmark/c/benchmark.length.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/benchmark/benchmark.ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/benchmark/benchmark.ndarray.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
lib/node_modules/@stdlib/blas/ext/base/dssumpw/benchmark/c/Makefile
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dssumpw/examples/c/Makefile
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
|
@Planeshifter are there any more changes that are required? |
|
@soumajit23 Looks like CI is failing for this PR. Until test and benchmark failures are addressed, this PR won't be able to move forward. |
Planeshifter
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # 1503
Description
This pull request:
Related Issues
This pull request:
blas/ext/base/dssumpwto follow current project conventions #1503Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers