-
-
Notifications
You must be signed in to change notification settings - Fork 836
refactor: update blas/ext/base/dapxsumpw
to follow current project conventions
#1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
blas/ext/base/dapxsumpw
to follow current project conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready for merge; just needs updates to the manifest.json
I believe. Thanks for your efforts!
@Planeshifter I think I understood what you wanted me to correct, and I have made the necessary adjustments, including adding the missing include and updating the dependencies in the |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Had to fix the indentation in the manifest file (make sure you have an .editorconfig
extension for your code editor installed, then the files should be auto-formatted on save), but otherwise looks all good to me now. Will merge shortly after CI has passed.
Resolves # .
Description
This pull request:
Related Issues
This pull request:
blas/ext/base/dapxsumpw
to follow current project conventions #1469Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers