Skip to content

feat: add C implementation for math/base/special/atan2 #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 26, 2024

Conversation

Pushpendra766
Copy link
Contributor

Resolves # .

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 21, 2024
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Planeshifter
Copy link
Member

/stdlib update-copyright-years

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I left an initial set of comments and suggestions that need to be addressed.

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 22, 2024
@Pushpendra766
Copy link
Contributor Author

/stdlib update-copyright-years

should I change it to 2024 ?

@Planeshifter
Copy link
Member

@Pushpendra766 The /stdlib update-copyright-years command automatically has our stdlib-bot update the copyright years for added files, see: 5c3356e. Just pull down the changes, no reason for you to manually change them.

@Pushpendra766
Copy link
Contributor Author

Pushpendra766 commented Mar 22, 2024

@Pushpendra766 The /stdlib update-copyright-years command automatically has our stdlib-bot update the copyright years for added files, see: 5c3356e. Just pull down the changes, no reason for you to manually change them.

Okay, thanks.
I have done the suggested changes. I hope it will fix the formatting and documentation issues.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is currently failing, please take a look. I think the manifest.json file is missing used packages in the examples and benchmark configurations, namely random/base/randu, but looks like we also have a problem with the implementation since the tests fail, although at first glance, it looks fine to me and matching the JS implementation.

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Pushpendra Chandravanshi <56391001+Pushpendra766@users.noreply.github.com>
@Pushpendra766
Copy link
Contributor Author

CI is currently failing, please take a look. I think the manifest.json file is missing used packages in the examples and benchmark configurations, namely random/base/randu, but looks like we also have a problem with the implementation since the tests fail, although at first glance, it looks fine to me and matching the JS implementation.

random/base/randu is not a dependency for atan2, as far as I know.
Also, I checked the implementation thoroughly. It matches the JavaScript implementation of the function.

Pushpendra766 and others added 2 commits March 24, 2024 18:37
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Pushpendra Chandravanshi <56391001+Pushpendra766@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Pushpendra Chandravanshi <56391001+Pushpendra766@users.noreply.github.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, everything works well. Thanks @Pushpendra766 !

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 25, 2024
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit 1cf574b into stdlib-js:develop Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/atan2
4 participants