-
-
Notifications
You must be signed in to change notification settings - Fork 836
feat: add C implementation for math/base/special/atan2
#1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for math/base/special/atan2
#1981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
/stdlib update-copyright-years |
lib/node_modules/@stdlib/math/base/special/atan2/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I left an initial set of comments and suggestions that need to be addressed.
should I change it to 2024 ? |
@Pushpendra766 The |
Okay, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is currently failing, please take a look. I think the manifest.json
file is missing used packages in the examples
and benchmark
configurations, namely random/base/randu
, but looks like we also have a problem with the implementation since the tests fail, although at first glance, it looks fine to me and matching the JS implementation.
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Pushpendra Chandravanshi <56391001+Pushpendra766@users.noreply.github.com>
|
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Pushpendra Chandravanshi <56391001+Pushpendra766@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Pushpendra Chandravanshi <56391001+Pushpendra766@users.noreply.github.com>
lib/node_modules/@stdlib/math/base/special/atan2/benchmark/c/native/benchmark.c
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/atan2/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/atan2/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/atan2/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/atan2/include/stdlib/math/base/special/atan2.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, everything works well. Thanks @Pushpendra766 !
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Resolves # .
Description
This pull request:
double out = stdlib_base_atan2( 2.0, 2.0 );
Related Issues
This pull request:
@stdlib/math/base/special/atan2
#1923Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers