Skip to content

refactor: update blas/ext/base/sasumpw to follow current project conventions #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 24, 2024
Merged

refactor: update blas/ext/base/sasumpw to follow current project conventions #1969

merged 13 commits into from
Mar 24, 2024

Conversation

ShivamAhir
Copy link
Contributor

Resolves # .

Description

refactor blas/ext/base/sasumpw to follow current project conventions #1515

This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 20, 2024
@Planeshifter Planeshifter changed the title refactor blas/ext/base/sasumpw to follow current project conventions #1515 refactor: update blas/ext/base/sasumpw to follow current project conventions Mar 21, 2024
Planeshifter
Planeshifter reviewed Mar 23, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 23, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 23, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall, thank you! Need to resolve what's causing CI to fail and left a few comments, but this should be ready soon.

Planeshifter
Planeshifter reviewed Mar 23, 2024
View reviewed changes
@Planeshifter Planeshifter added Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 23, 2024
Planeshifter
Planeshifter reviewed Mar 24, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 24, 2024
View reviewed changes
@Planeshifter
fix: use float32 instead of float64 array
cb8b44c 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
style: fix indentation
89fa692 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that there was a copy-paste error using float64 instead of float32 in addon.c and that CI was subsequently failing. Things pass now and I will merge your PR soon. Thanks for your contribution!

@Planeshifter Planeshifter merged commit f1c46cd into stdlib-js:develop Mar 24, 2024
@ShivamAhir ShivamAhir mentioned this pull request Mar 25, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/sasumpw to follow current project conventions
3 participants
@ShivamAhir @Planeshifter @stdlib-bot