-
-
Notifications
You must be signed in to change notification settings - Fork 836
refactor: update blas/ext/base/dsumors
to follow current project conventions
#1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
blas/ext/base/dsumors
to follow current project conventions
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
@Planeshifter @kgryte Pinging for review |
Signed-off-by: Shivam <11shivam00@gmail.com>
lib/node_modules/@stdlib/blas/ext/base/dsumors/test/test.dsumors.js
Outdated
Show resolved
Hide resolved
@@ -34,7 +34,12 @@ | |||
"-lm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change indentation of the manifest.json
to 2-space and add configurations for benchmarks and examples. See the linked changes in the RFC issue or some of the recently merged PRs for how this will look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Left an initial set of comments.
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did another review pass; looks all good to me now. Will merge soon once CI has passed.
Resolves # .
Description
refactor blas/ext/base/dsumors to follow current project conventions #1507
This pull request:
Related Issues
This pull request:
blas/ext/base/dsumors
to follow current project conventions #1507Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers