Skip to content

refactor: update blas/ext/base/dsumors to follow current project conventions #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 24, 2024

Conversation

ShivamAhir
Copy link
Contributor

Resolves # .

Description

refactor blas/ext/base/dsumors to follow current project conventions #1507

This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 20, 2024
@Planeshifter Planeshifter changed the title refactor blas/ext/base/dsumors to follow current project conventions #1507 refactor: update blas/ext/base/dsumors to follow current project conventions Mar 21, 2024
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
Signed-off-by: Shivam <11shivam00@gmail.com>
@ShivamAhir
Copy link
Contributor Author

@Planeshifter @kgryte Pinging for review

Signed-off-by: Shivam <11shivam00@gmail.com>
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 23, 2024
@@ -34,7 +34,12 @@
"-lm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change indentation of the manifest.json to 2-space and add configurations for benchmarks and examples. See the linked changes in the RFC issue or some of the recently merged PRs for how this will look.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Left an initial set of comments.

@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 24, 2024
@Planeshifter Planeshifter added the Needs Changes Pull request which needs changes before being merged. label Mar 24, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another review pass; looks all good to me now. Will merge soon once CI has passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants