Skip to content

refactor: blas/ext/base/sapxsumkbn2 to follow current project conventions #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 24, 2024
Merged

refactor: blas/ext/base/sapxsumkbn2 to follow current project conventions #1966

merged 32 commits into from
Mar 24, 2024

Conversation

ShivamAhir
Copy link
Contributor

Resolves # .

Description

refactor blas/ext/base/sapxsumkbn2 to follow current project conventions #1512

This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 20, 2024
@Planeshifter Planeshifter changed the title refactor blas/ext/base/sapxsumkbn2 to follow current project conventions refactor blas/ext/base/sapxsumkbn2 to follow current project conventions Mar 21, 2024
@kgryte kgryte changed the title refactor blas/ext/base/sapxsumkbn2 to follow current project conventions refactor: blas/ext/base/sapxsumkbn2 to follow current project conventions Mar 22, 2024
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 22, 2024
@ShivamAhir
Update benchmark.native.js
1bffc35 
Signed-off-by: Shivam <11shivam00@gmail.com>
@ShivamAhir
Update benchmark.ndarray.js
8a0823b 
Signed-off-by: Shivam <11shivam00@gmail.com>
@ShivamAhir
Update benchmark.ndarray.native.js
ddd1597 
Signed-off-by: Shivam <11shivam00@gmail.com>
@ShivamAhir
Update index.js
011eae7 
Signed-off-by: Shivam <11shivam00@gmail.com>
@ShivamAhir
Update test.ndarray.js
3bac932 
Signed-off-by: Shivam <11shivam00@gmail.com>
@ShivamAhir
Update test.ndarray.native.js
d7481e9 
Signed-off-by: Shivam <11shivam00@gmail.com>
@ShivamAhir
Update test.sapxsumkbn2.js
5891cbe 
Signed-off-by: Shivam <11shivam00@gmail.com>
@ShivamAhir
Update test.sapxsumkbn2.native.js
b147bbe 
Signed-off-by: Shivam <11shivam00@gmail.com>
@ShivamAhir
Update README.md
de7a754 
Signed-off-by: Shivam <11shivam00@gmail.com>
Planeshifter
Planeshifter reviewed Mar 24, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 24, 2024
View reviewed changes
Planeshifter
Planeshifter reviewed Mar 24, 2024
View reviewed changes
Planeshifter
Planeshifter requested changes Mar 24, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left a bunch of comments, mirroring some of the requested changes for your other PRs. Once addressed and we get CI to pass, this should be ready to land.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 24, 2024
Planeshifter
Planeshifter approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your edits! Will merge shortly after CI has passed.

@Planeshifter Planeshifter merged commit 8e8b47c into stdlib-js:develop Mar 24, 2024
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 24, 2024
@ShivamAhir ShivamAhir mentioned this pull request Mar 25, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/sapxsumkbn2 to follow current project conventions
4 participants
@ShivamAhir @Planeshifter @kgryte @stdlib-bot