Skip to content

feat: add C implementation for math/base/special/fast/uint32-sqrt #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 24, 2024
Merged

feat: add C implementation for math/base/special/fast/uint32-sqrt #1960

merged 15 commits into from
Mar 24, 2024

Conversation

kawaho2
Copy link
Contributor

@kawaho2 kawaho2 commented Mar 19, 2024 •
edited
Loading

Resolves #1932

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/special/fast/uint32-sqrt

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 19, 2024
kawaho2 added 6 commits March 20, 2024 03:07
@kawaho2
Rename main.c to floor.c
6c7b1d8 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update benchmark.c
05fed59 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update and rename floor.c to main.c
22437b8 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Rename main.c to floor.c
1da601f 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update floor.c
2719252 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update floor.c
51c6246 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2 kawaho2 closed this Mar 19, 2024
@kawaho2 kawaho2 deleted the uint32-sqrt branch March 19, 2024 22:18
@kawaho2 kawaho2 restored the uint32-sqrt branch March 20, 2024 19:12
@kawaho2 kawaho2 reopened this Mar 20, 2024
kawaho2 added 6 commits March 21, 2024 00:46
@kawaho2
Update benchmark.c
315e46f 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update and rename floor.c to main.c
f3b5141 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Rename main.c to floor.c
475865a 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update floor.c
5959b48 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update floor.c
8cc7af5 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update floor.c
7081370 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 24, 2024
Planeshifter
Planeshifter requested changes Mar 24, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a few comments and questions that need to be addressed, but otherwise this PR should be ready to land.

@kgryte kgryte mentioned this pull request Mar 24, 2024
Closed
1 task
kawaho2 added 2 commits March 24, 2024 14:26
@kawaho2
Update manifest.json
a85ff16 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Update and rename floor.c to main.c
4433f7b 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
@kawaho2
Copy link
Contributor Author

kawaho2 commented Mar 24, 2024

Thanks! Left a few comments and questions that need to be addressed, but otherwise this PR should be ready to land.

@Planeshifter I have addressed all the issues you mentioned in your review.

@kawaho2 kawaho2 requested a review from Planeshifter March 24, 2024 10:50
Planeshifter
Planeshifter approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks! Let's get it in.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 24, 2024
@Planeshifter Planeshifter merged commit 8a01cf7 into stdlib-js:develop Mar 24, 2024
@kawaho2 kawaho2 deleted the uint32-sqrt branch March 24, 2024 21:44
@gunjjoshi gunjjoshi mentioned this pull request Mar 25, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for @stdlib/math/base/special/fast/uint32-sqrt
3 participants
@kawaho2 @Planeshifter @stdlib-bot