refactor: update blas/ext/base/drev to follow current project conventions
#1839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions This commit refactors the namespace to follow current project conventions i.e. C++ add-on interfaces to C add-on interfaces along with style and simplification changes.
|
Hi, I am not able to trace through the error since it's not related to an import but a header file and it seems to be included in the code that utilizes it. If you could guide me on debugging the error, that'd be great (@Planeshifter , @kgryte , @Pranavchiku )! Thanks! |
|
Can you merge latest main to this PR and check? |
Pranavchiku
reviewed
Mar 12, 2024
Pranavchiku
reviewed
Mar 12, 2024
lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 12, 2024
lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 12, 2024
lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.ndarray.js
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 12, 2024
lib/node_modules/@stdlib/blas/ext/base/drev/benchmark/benchmark.ndarray.native.js
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 12, 2024
Pranavchiku
reviewed
Mar 12, 2024
lib/node_modules/@stdlib/blas/ext/base/drev/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
changed the title
blas/ext/base/drev to follow current project conventions
Pranavchiku
added
the
BLAS
Hi @Pranavchiku, you mean the develop branch right? |
Pranavchiku
approved these changes
Mar 12, 2024
|
@Pranavchiku, Thank you so much for your review, I have pulled the latest changes into the PR! cc @Planeshifter. |
kgryte
added
Native Addons
kgryte
reviewed
Mar 13, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 13, 2024
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 13, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 13, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 13, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Mar 13, 2024
|
I am not sure the cause of the failing builds when running C examples. |
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Mar 13, 2024
kgryte
added
the
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1488.
Description
This PR refactors
blas/ext/base/drevto follow current project conventions, by updating C++ add-on interfaces to C add-on interfaces along with style and simplification changes.Related Issues
This pull request:
blas/ext/base/drevto follow current project conventions #1488Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers