feat: add C implementation for `math/base/special/max` #1459

Shashankss1205 · 2024-03-02T22:54:46Z

Resolves #1433 .

Description

This pull request adds native C implementation for
@stdlib/math/base/special/max for issue #1433 .

What is the purpose of this pull request?
Native C implementation of max function
This pull request:

a
b
c

Related Issues

Does this pull request have any related issues?

This pull request:

resolves #
fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Pranavchiku

Requested changes, once done this PR can be reviewed again.

lib/node_modules/@stdlib/math/base/special/max/README.md

lib/node_modules/@stdlib/math/base/special/max/benchmark/c/Makefile

lib/node_modules/@stdlib/math/base/special/max/benchmark/c/native/benchmark.c

lib/node_modules/@stdlib/math/base/special/max/manifest.json

Signed-off-by: Shashank Shekhar Singh <123410790+Shashankss1205@users.noreply.github.com>

lib/node_modules/@stdlib/math/base/special/max/README.md

Pranavchiku

Few more changes and this be good to merge.

lib/node_modules/@stdlib/math/base/special/max/README.md

lib/node_modules/@stdlib/math/base/special/max/benchmark/c/Makefile

lib/node_modules/@stdlib/math/base/special/max/benchmark/c/benchmark.c

lib/node_modules/@stdlib/math/base/special/max/src/addone.c

lib/node_modules/@stdlib/math/base/special/max/src/main.c

Signed-off-by: Shashank Shekhar Singh <123410790+Shashankss1205@users.noreply.github.com>

Shashankss1205 · 2024-03-03T14:15:36Z

please close the PR if the issue has been resolved @Pranavchiku .

Pranavchiku

Almost done, minor changes and this will be ready.

lib/node_modules/@stdlib/math/base/special/max/README.md

lib/node_modules/@stdlib/math/base/special/max/benchmark/benchmark.native.js

lib/node_modules/@stdlib/math/base/special/max/benchmark/c/benchmark.c

lib/node_modules/@stdlib/math/base/special/max/binding.gyp

lib/node_modules/@stdlib/math/base/special/max/examples/c/Makefile

lib/node_modules/@stdlib/math/base/special/max/include.gypi

lib/node_modules/@stdlib/math/base/special/max/include/stdlib/math/base/special/max.h

lib/node_modules/@stdlib/math/base/special/max/lib/native.js

lib/node_modules/@stdlib/math/base/special/max/manifest.json

lib/node_modules/@stdlib/math/base/special/max/src/Makefile

Shashankss1205 · 2024-03-05T14:54:17Z

Please take a look at this once @Pranavchiku . Sorry for the extraneous commits, I will try to keep them clean from the next PR's

…o debug2

Shashankss1205 · 2024-03-09T15:32:39Z

Please take a look at this once @Pranavchiku @Planeshifter.

Sorry for the extraneous commits, I will try to keep them clean from the next PR's I am just a beginner in open source.

lib/node_modules/@stdlib/math/base/special/max/src/main.c

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

lib/node_modules/@stdlib/math/base/special/max/src/main.c

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Planeshifter

LGTM! Will merge once CI checks have cleared.

Thank you!

feat: Add C implementation for @stdlib/math/base/special/max

10b24bf

Shashankss1205 mentioned this pull request Mar 2, 2024

[RFC]: Add C implementation for @stdlib/math/base/special/max #1433

Closed

3 tasks

Pranavchiku suggested changes Mar 3, 2024

View reviewed changes

Pranavchiku added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 3, 2024

Shashankss1205 and others added 6 commits March 3, 2024 14:08

Update README.md

3b13624

Signed-off-by: Shashank Shekhar Singh <123410790+Shashankss1205@users.noreply.github.com>

Update README.md

558a5e8

Signed-off-by: Shashank Shekhar Singh <123410790+Shashankss1205@users.noreply.github.com>

fix: requested changes made for stdlib-js#1459

ad72477

fix: requested changes made for stdlib-js#1459

7ca9907

fix: requested changes made for stdlib-js#1459

215caf6

fix: requested changes made for stdlib-js#1459

339177b

Shashankss1205 requested a review from Pranavchiku March 3, 2024 09:46

Pranavchiku reviewed Mar 3, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/max/README.md Outdated Show resolved Hide resolved

Pranavchiku suggested changes Mar 3, 2024

View reviewed changes

Pranavchiku changed the title ~~feat: Add C implementation for @stdlib/math/base/special/max~~ feat: Add C implementation for @stdlib/math/base/special/max Mar 3, 2024

Shashankss1205 added 4 commits March 3, 2024 18:57

Update README.md

ec098db

Signed-off-by: Shashank Shekhar Singh <123410790+Shashankss1205@users.noreply.github.com>

Update Makefile

082e63c

Signed-off-by: Shashank Shekhar Singh <123410790+Shashankss1205@users.noreply.github.com>

Rename addone.c to addon.c

7eea6e5

Signed-off-by: Shashank Shekhar Singh <123410790+Shashankss1205@users.noreply.github.com>

Update main.c

29c24e6

Signed-off-by: Shashank Shekhar Singh <123410790+Shashankss1205@users.noreply.github.com>

Shashankss1205 requested a review from Pranavchiku March 3, 2024 13:32

Planeshifter changed the title ~~feat: Add C implementation for @stdlib/math/base/special/max~~ feat: dd C implementation for math/base/special/max Mar 3, 2024

Planeshifter changed the title ~~feat: dd C implementation for math/base/special/max~~ feat: Add C implementation for math/base/special/max Mar 3, 2024

Planeshifter changed the title ~~feat: Add C implementation for math/base/special/max~~ feat: add C implementation for math/base/special/max Mar 3, 2024

kgryte mentioned this pull request Mar 4, 2024

feat: add C implementation for math/base/special/maxabs #1671

Merged

1 task

Pranavchiku suggested changes Mar 4, 2024

View reviewed changes

Shashankss1205 and others added 3 commits March 4, 2024 22:11

Merge branch 'stdlib-js:develop' into debug2

b9ecae8

Merge branch 'stdlib-js:develop' into debug2

1523e4e

fix: add C implementation for @stdlib/math/base/assert/max

5b260f9

Shashankss1205 added 3 commits March 5, 2024 19:53

fix: add C implementation for @stdlib/math/base/assert/max

d23210d

fix: add C implementation for @stdlib/math/base/assert/max

12df0eb

fix: add C implementation for @stdlib/math/base/assert/max

580d98d

Shashankss1205 and others added 11 commits March 9, 2024 17:17

Merge branch 'stdlib-js:develop' into debug2

d21df59

fix: new line added at the end of each file

b2297da

fix: new line added at the end of each file

38b22bf

fix: new line added at the end of each file

6edc185

fix: new line added at the end of each file

6ffaa62

fix: new line added at the end of each file

3547778

fix: new line added at the end of each file

8cb91f2

fix: new line added at the end of each file

0c9382d

fix: new line added at the end of each file

874cf69

fix: new line added at the end of each file

d01fa73

Merge branch 'debug2' of https://github.com/Shashankss1205/stdlib int…

9d9064b

…o debug2

Planeshifter reviewed Mar 10, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/max/src/main.c Outdated Show resolved Hide resolved

Update lib/node_modules/@stdlib/math/base/special/max/src/main.c

d90b327

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Planeshifter reviewed Mar 10, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/max/src/main.c Outdated Show resolved Hide resolved

Update lib/node_modules/@stdlib/math/base/special/max/src/main.c

dfd9a22

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Planeshifter approved these changes Mar 10, 2024

View reviewed changes

Planeshifter merged commit 6831521 into stdlib-js:develop Mar 10, 2024

Uh oh!

feat: add C implementation for math/base/special/max #1459

feat: add C implementation for math/base/special/max #1459

Uh oh!

Conversation

Shashankss1205 commented Mar 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

Pranavchiku left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pranavchiku left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Shashankss1205 commented Mar 3, 2024

Uh oh!

Pranavchiku left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Shashankss1205 commented Mar 5, 2024

Uh oh!

Shashankss1205 commented Mar 9, 2024

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

feat: add C implementation for `math/base/special/max` #1459

feat: add C implementation for `math/base/special/max` #1459

Shashankss1205 commented Mar 2, 2024 •

edited

Loading

Planeshifter left a comment •

edited

Loading