Skip to content

feat: add string/base/stickycase #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Mar 5, 2024

Conversation

anudeeps0306
Copy link
Contributor

Resolves #852

Description

This PR adds implementation for @stdlib/string/base/stickycase

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Implemented the stickycase function.

This commit adds the stickycase function to the string module, which converts a string to 'sticky caps' case.

BREAKING CHANGE: None
Corrected the JavaScript example in the README.md file to define the 'out' variable before assignment, preventing an 'out is not defined' error. Now the example runs correctly.

No breaking changes introduced.
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@anudeeps0306 anudeeps0306 changed the title Stickycase feast : add @stdlib/string/base/stickycase Mar 2, 2024
@anudeeps0306 anudeeps0306 changed the title feast : add @stdlib/string/base/stickycase feat : add @stdlib/string/base/stickycase Mar 2, 2024
@kgryte kgryte changed the title feat : add @stdlib/string/base/stickycase feat : add string/base/stickycase Mar 2, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. labels Mar 2, 2024
@Planeshifter Planeshifter changed the title feat : add string/base/stickycase feat: add string/base/stickycase Mar 2, 2024
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR! There are a bunch of issues that will have to be addressed before this can be merged, but hopefully they should be straightforward to do.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 4, 2024
anudeeps0306 and others added 13 commits March 4, 2024 09:14
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
…ex.d.ts

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
…t.ts

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
…ex.d.ts

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
…ex.d.ts

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
…t.ts

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
anudeeps0306 and others added 6 commits March 4, 2024 09:24
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
 Refactor test cases and add additional parameter validation

Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Copy link
Member

@anudeeps0306 CI is now passing and things look good; let's get this in! Thanks for your contribution!

@Planeshifter Planeshifter merged commit 84a6f4b into stdlib-js:develop Mar 5, 2024
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this pull request Mar 7, 2024
PR-URL: stdlib-js#1447
Closes: stdlib-js#852

---------

Signed-off-by: Anudeep Sanapala <71971574+anudeeps0306@users.noreply.github.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add @stdlib/string/base/stickycase
4 participants