feat: add C implementation for math/base/special/logaddexp
#1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
suggested changes
Mar 2, 2024
lib/node_modules/@stdlib/math/base/special/logaddexp/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/logaddexp/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/logaddexp/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/logaddexp/examples/c/example.c
Outdated
Show resolved
Hide resolved
...ode_modules/@stdlib/math/base/special/logaddexp/include/stdlib/math/base/special/logaddexp.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/logaddexp/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/logaddexp/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/logaddexp/src/main.c
Outdated
Show resolved
Hide resolved
Pranavchiku
added
the
Needs Changes
Pranavchiku
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
There is a minor comment I'll let Athan or Phillip address, rest all looks good to me. Thanks @aman-095!
lib/node_modules/@stdlib/math/base/special/logaddexp/src/main.c
Outdated
Show resolved
Hide resolved
Pranavchiku
added
Ready To Merge
kgryte
changed the title
@stdlib/math/base/special/logaddexpmath/base/special/logaddexp
kgryte
added
Feature
Pranavchiku
reviewed
Mar 2, 2024
lib/node_modules/@stdlib/math/base/special/logaddexp/src/main.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
Thanks @aman-095 for your work! I'll recommend you to shift towards slightly more difficult packages :)
Pranavchiku
added
Ready To Merge
bad-in-coding
pushed a commit
to bad-in-coding/stdlib
that referenced
this pull request
Mar 7, 2024
PR-URL: stdlib-js#1442 Closes: stdlib-js#1432 --------- Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1432.
Description
This pull request adds native C implementation for
@stdlib/math/base/special/logaddexpRelated Issues
This pull request:
@stdlib/math/base/special/logaddexp#1432Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers