Skip to content

feat: added utils/every-in-by #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 2, 2024
Merged

feat: added utils/every-in-by #1409

merged 11 commits into from
Mar 2, 2024

Conversation

saisrikardumpeti
Copy link
Contributor

@saisrikardumpeti saisrikardumpeti commented Feb 28, 2024 •
edited
Loading

Resolves #822

Description

What is the purpose of this pull request?

This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Planeshifter
Copy link
Member

@the-r3aper7 This package is currently missing a README.md file. Would you mind adding it, please?

@saisrikardumpeti
Copy link
Contributor Author

@Planeshifter i have added README.md file.

Planeshifter
Planeshifter requested changes Mar 1, 2024
View reviewed changes
@saisrikardumpeti
Copy link
Contributor Author

@Planeshifter i have made the changes as you suggested.

@Planeshifter
style: add missing spaces
24641e5 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few changes to get this over the finish line; will merge once CI passes.

Thanks for your contribution!

@Planeshifter
Update lib/node_modules/@stdlib/utils/every-by/docs/types/index.d.ts
6e76aa5 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/utils/every-in-by/docs/repl.txt
30a0211 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/utils/every-in-by/docs/types/index.d.ts
6ccb0b9 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/utils/every-in-by/docs/types/index.d.ts
818222e 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit 87ec7c2 into stdlib-js:develop Mar 2, 2024
@saisrikardumpeti saisrikardumpeti deleted the every-in-by branch March 2, 2024 04:34
@saisrikardumpeti saisrikardumpeti mentioned this pull request Mar 15, 2024
Closed
5 tasks
@kawaho2 kawaho2 mentioned this pull request Mar 17, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add @stdlib/utils/every-in-by
3 participants
@saisrikardumpeti @Planeshifter @stdlib-bot