Skip to content

feat: added iter/until-each #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

JawHawk
Copy link
Contributor

@JawHawk JawHawk commented Feb 26, 2024

This commit adds the iter/until-each utility.
Resolves #809 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds an Iterator utility to invoke a function for each iterated value until a predicate function returns true.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@JawHawk JawHawk changed the title feat: added iter/until-each feat: added @iter/until-each Feb 26, 2024
@JawHawk JawHawk changed the title feat: added @iter/until-each feat: added iter/until-each Feb 26, 2024
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@Planeshifter Planeshifter self-requested a review February 26, 2024 14:48
@Planeshifter
Copy link
Member

Planeshifter commented Feb 26, 2024

@JawHawk There are a few lint errors that will need to be addressed flagged by CI. You mind taking a look at these, please?

Thanks for working on this package!

@JawHawk
Copy link
Contributor Author

JawHawk commented Feb 26, 2024

@Planeshifter I have made the necessary changes.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much for working on this @JawHawk!

@Planeshifter Planeshifter merged commit 73ab86a into stdlib-js:develop Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add @stdlib/iter/until-each
3 participants