feat: add assert/is-ragged-nested-array

[performant23]

Add support for checking if array-like objects are ragged and nested.

Resolves #1347

Description

What is the purpose of this pull request?

This pull request:

• Adds support for checking if array-like objects are ragged and nested.

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves [RFC]: add @stdlib/assert/is-ragged-nested-array #1347

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The test results when applied on the functionality (benchmarks, examples, tests) can be found here - https://drive.google.com/drive/folders/1AomH4BL-sKkQCO6lhFU5BUelUW3wZp4f?usp=sharing

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

[Pranavchiku]

Please address following suggestion, also run the tests, benchmarks prior to pushing the changes.

[performant23]

Hello, I have modified the files, marked the suggestions as done, and pushed the commit with the changes! Please do let me know if there are any further changes necessary.

[kgryte]

Suggested change

	console.log( isRaggedNestedArray( [ [1, 2, 3], [4, 5] ] ) );
	// => true
	console.log( isRaggedNestedArray( [ [1, 2, 3], [4, 5, 6] ] ) );
	console.log( isRaggedNestedArray( [ [ 1, 2, 3 ], [ 4, 5 ] ] ) );
	// => true
	console.log( isRaggedNestedArray( [ [ 1, 2, 3 ], [ 4, 5, 6 ] ] ) );

Here and elsewhere.

[performant23]

Thanks for the suggestion @kgryte! Just to confirm, you mean adding a leading and trailing whitespace in array initializations in all files in the package not just this one right?

[Pranavchiku]

Yes

[kgryte]

Suggested change

	var len = -1;
	var i;
	if ( !isArrayLikeObject( value ) ) {
	return false;
	}
	for ( i = 0; i < value.length; i++ ) {
	if ( !isArrayLikeObject( value[i] ) ) {
	return false;
	}
	if ( len === -1 ) {
	len = value[i].length;
	} else if ( value[i].length !== len ) {
	var len;
	var i;
	if ( !isArrayLikeObject( value ) || value.length < 2 ) {
	return false;
	}
	len = value[ 0 ].length;
	for ( i = 1; i < value.length; i++ ) {
	if ( !isArrayLikeObject( value[ i ] ) ) {
	return false;
	}
	if ( value[ i ].length !== len ) {

Empty and single element arrays are not ragged. You can avoid additional branching logic by caching the length of the first array.

[kgryte]

The indentation in this file is off.

[kgryte]

Missing newline.

[kgryte]

Suggested change

	"israggednestedarray",
	"isarray",

[kgryte]

Test files should never have unused variables.

[performant23]

That's correct, thanks! Also, just noticed that the package 'is-array-like-object', had this line in the test.js file.
/* eslint-disable object-curly-newline, no-unused-vars */
I'm not sure if it's the expected behavior there, but in case it isn't, just letting you know!

Edit: So, just noticed that this is used 20 times in 9 files in node_modules/@StdLib

[kgryte]

Spacing.

[kgryte]

Add empty array and [ [ 1, 2, 3 ] ].

[kgryte]

Thanks for working on this, @performant23. This is shaping up. So long as the comments are addressed, this is on track for being merged.

[performant23]

Hey everyone, I have modified the files and pushed the commit with the changes! Please do let me know if there are any further changes necessary.

[Planeshifter]

Thanks for making the requested changes and your contribution, @performant23! This looks good to me; will merge shortly.