Skip to content

refactor: use generics to improve type declarations for async/if then #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

prajwalkulkarni
Copy link
Contributor

Resolves #1096

Description

What is the purpose of this pull request?

This pull request:

  • Adds generics for improved type safety for the ifthenAsync function.
  • Uses generic parameter defaults for optional generic types U & V.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@kgryte
Copy link
Member

kgryte commented Feb 24, 2024

@Planeshifter Would you mind reviewing this?

@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. TypeScript Issue involves or relates to TypeScript. Needs Review A pull request which needs code review. labels Feb 24, 2024
@kgryte kgryte requested a review from Planeshifter February 24, 2024 09:43
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prajwalkulkarni Thanks for submitting this PR. LGTM!

@Planeshifter Planeshifter merged commit 174544f into stdlib-js:develop Feb 24, 2024
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Issue or pull request for enhancing existing functionality. TypeScript Issue involves or relates to TypeScript.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: improve type declarations for @stdlib/utils/async/if-then
4 participants