Skip to content

Hardcode the use of the "default" profile for rustup #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025

Conversation

lfrancke
Copy link
Member

At some point rustup changed the default profile from "default" to "minimal" if no other profile was specified.

This caused our pre-commit checks to fail which rely on clippy which is not in the "minimal" profile.
We now specify our dependency on the "default" profile explicitly to be more independent of future rustup changes.

At some point rustup changed the default profile from "default" to
"minimal" if no other profile was specified.

This caused our pre-commit checks to fail which rely on clippy which is
not in the "minimal" profile.
We now specify our dependency on the "default" profile explicitly to be
more independent of future rustup changes.
@lfrancke lfrancke self-assigned this May 31, 2025
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering May 31, 2025
@lfrancke
Copy link
Member Author

I created an example PR here: stackabletech/hive-operator#606

Cargo will automatically install missing components/profiles if they are not already installed but specified in the rust-toolchain.toml file.

@lfrancke lfrancke enabled auto-merge May 31, 2025 12:35
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we might want to list out the specific components we care about. But this is fine for now.

@lfrancke lfrancke added this pull request to the merge queue May 31, 2025
Merged via the queue into main with commit 4d5535d May 31, 2025
2 checks passed
@lfrancke lfrancke deleted the feat/hardcode-profile branch May 31, 2025 12:37
@nightkr
Copy link
Member

nightkr commented May 31, 2025

FWIW, this will end up in the same templating batch as #524, so we'll likely need to manually cargo +nightly fmt --all each PR.

@lfrancke
Copy link
Member Author

Yeah, my initial attempt was to list all components but the docs say they can change between versions of rust.
I have no strong opinion here. If anyone prefers I can also put up a PR to list the current components from default profile.

This will also include the OpenSearch operator inclusion which might also cause this to fail because that repo is private at the moment. If it does we'll have to remove it again for now.

@lfrancke lfrancke moved this from Development: Waiting for Review to Development: Done in Stackable Engineering May 31, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants