Skip to content

chore: bump kube, update status type in stackable-versioned #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 17, 2025
Merged

chore: bump kube, update status type in stackable-versioned #982

merged 8 commits into from
Mar 17, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Mar 13, 2025 •
edited
Loading

Description

This PR

  • bumps kube crate version
  • changes the Type of status in KubernetesArguments / KubernetesOptions structs of stackable-versioned crate

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@xeniape xeniape self-assigned this Mar 13, 2025
@xeniape xeniape changed the title chore: bump kube, update status type in stackable-versioned chore: bump kube Mar 17, 2025
@xeniape xeniape changed the title chore: bump kube chore: bump kube, update status type in stackable-versioned Mar 17, 2025
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Mar 17, 2025
@Techassi Techassi self-requested a review March 17, 2025 13:13
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 17, 2025
Techassi
Techassi reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small suggestion.

@xeniape @Techassi
Update crates/stackable-versioned/CHANGELOG.md
9fa5ae5 
Co-authored-by: Techassi <git@techassi.dev>
@xeniape xeniape requested a review from Techassi March 17, 2025 14:54
@xeniape xeniape enabled auto-merge March 17, 2025 15:09
@xeniape xeniape added this pull request to the merge queue Mar 17, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Mar 17, 2025
Merged via the queue into main with commit d71f8b2 Mar 17, 2025
10 checks passed
@xeniape xeniape deleted the chore/bump-kube-update-status-option-type branch March 17, 2025 15:58
@Techassi Techassi mentioned this pull request Mar 21, 2025
Open
81 tasks
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@xeniape xeniape

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xeniape @Techassi