Skip to content

fix: Fix Kubernetes cluster domain parsing from resolv.conf #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 21, 2024

Description

This fixes a bug on AWS EKS:

Given the resolv.conf

search default.svc.cluster.local svc.cluster.local cluster.local ec2.internal
nameserver 172.20.0.10
options ndots:5

the operators logged

retrieve_cluster_domain: stackable_operator::utils::cluster_domain: Using Kubernetes cluster domain from "/etc/resolv.conf" file cluster_domain=ec2.internal.

However, they should have used cluster.local. This PR fixes that.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 21, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer
Copy link
Member Author

Let's merge this, knowing that we will very likely rip out the parsing in the very near future, just to avoid re-adding a buggy version.

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 60cb372 Oct 22, 2024
10 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/k8s-cluster-domain-parsing branch October 22, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants