Skip to content

feat(stackable-versioned): Add basic handling for enum variants with data #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2024
Merged

feat(stackable-versioned): Add basic handling for enum variants with data #892

merged 5 commits into from
Oct 15, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Oct 14, 2024 •
edited
Loading

Description

Part of stackabletech/issues#642.

  • stackable-versioned: Add basic handling for enum variants with data, with a snapshot test.
    TODO: Handle versioning of named/unnamed enum fields.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

@NickLarsenNZ NickLarsenNZ self-assigned this Oct 14, 2024
Techassi
Techassi previously approved these changes Oct 15, 2024
View reviewed changes
@NickLarsenNZ NickLarsenNZ force-pushed the fix/stackable-versioned-enum-data branch from 28eaddd to 7c5db4e Compare October 15, 2024 08:49
@NickLarsenNZ NickLarsenNZ changed the title fix: Allow various formatting styles for macro in testing regex feat(stackable-versioned): basic handling for enum variants with data Oct 15, 2024
@NickLarsenNZ NickLarsenNZ changed the title feat(stackable-versioned): basic handling for enum variants with data feat(stackable-versioned): Add basic handling for enum variants with data Oct 15, 2024
@NickLarsenNZ NickLarsenNZ requested a review from Techassi October 15, 2024 09:59
@NickLarsenNZ NickLarsenNZ mentioned this pull request Oct 15, 2024
Open
80 tasks
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 244eda7 Oct 15, 2024
10 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/stackable-versioned-enum-data branch October 15, 2024 10:22
@Techassi Techassi mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickLarsenNZ @Techassi