Skip to content

Check for ownerReferences in ClusterResources #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2024
Merged

Check for ownerReferences in ClusterResources #862

merged 2 commits into from
Sep 11, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Sep 11, 2024 •
edited
Loading

Description

Fixes #861.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [ ] Integration tests passed (for non trivial changes)
  - [x] Tested manually

# Reviewer
- [x] Code contains useful comments
- [ ] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@nightkr nightkr requested a review from a team September 11, 2024 13:41
@maltesander maltesander requested review from maltesander and removed request for a team September 11, 2024 14:25
maltesander
maltesander approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nightkr nightkr enabled auto-merge September 11, 2024 15:00
@nightkr nightkr added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 5c45d27 Sep 11, 2024
10 checks passed
@nightkr nightkr deleted the bugfix/clusterresources-ownerreferences branch September 11, 2024 15:22
@Techassi Techassi mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClusterResources::delete_orphaned_resources also deletes objects that are not owned directly by it
2 participants
@nightkr @maltesander