Skip to content

[Merged by Bors] - Add affinity structs #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - Add affinity structs #556

wants to merge 13 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Feb 16, 2023 •
edited
Loading

Description

For stackabletech/issues#323

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer changed the title Deploy default and support custom affinities Add affinity structs Feb 16, 2023
@sbernauer sbernauer self-assigned this Feb 16, 2023
@sbernauer sbernauer marked this pull request as ready for review February 16, 2023 14:48
@razvan razvan self-requested a review February 17, 2023 09:27
razvan
razvan reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A changelog entry is missing.

sbernauer and others added 3 commits February 17, 2023 11:13
@sbernauer @razvan
Update src/commons/affinities.rs
7a14122 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@sbernauer
Move kubernetes.io/hostname into constant
a5d7805
@sbernauer
fix docs
837a104
razvan
razvan reviewed Feb 17, 2023
View reviewed changes
@sbernauer sbernauer requested a review from razvan February 17, 2023 12:56
@razvan razvan mentioned this pull request Feb 17, 2023
Closed
sbernauer
sbernauer commented Feb 17, 2023
View reviewed changes
@sbernauer
Copy link
Member Author

Added some rustdoc

razvan
razvan approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 17, 2023
@sbernauer
Add affinity structs (#556)
b655fe7 
## Description

For stackabletech/issues#323
@bors
Copy link
Contributor

bors bot commented Feb 17, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add affinity structs [Merged by Bors] - Add affinity structs Feb 17, 2023
@bors bors bot closed this Feb 17, 2023
@bors bors bot deleted the feat/affinities branch February 17, 2023 15:00
@sbernauer sbernauer mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @razvan