-
-
Notifications
You must be signed in to change notification settings - Fork 15
feat(stackable-versioned): Generate downgrade From impls #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Techassi
merged 31 commits into
main
from
feat/stackable-versioned-downgrade-from-impls
May 22, 2025
Merged
feat(stackable-versioned): Generate downgrade From impls #1033
Techassi
merged 31 commits into
main
from
feat/stackable-versioned-downgrade-from-impls
May 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53fe2c7
to
3fc0b82
Compare
sbernauer
requested changes
May 16, 2025
crates/stackable-versioned-macros/src/codegen/container/struct.rs
Outdated
Show resolved
Hide resolved
crates/stackable-versioned-macros/src/codegen/container/struct.rs
Outdated
Show resolved
Hide resolved
crates/stackable-versioned-macros/src/codegen/container/struct.rs
Outdated
Show resolved
Hide resolved
crates/stackable-versioned-macros/src/codegen/container/struct.rs
Outdated
Show resolved
Hide resolved
81 tasks
sbernauer
requested changes
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my points, another round of review :)
crates/stackable-versioned-macros/tests/inputs/default/pass/convert_with.rs
Outdated
Show resolved
Hide resolved
sbernauer
requested changes
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there is still one leftover:
diff --git a/crates/stackable-versioned-macros/tests/trybuild.rs b/crates/stackable-versioned-macros/tests/trybuild.rs
index 891cc60..d58c32d 100644
--- a/crates/stackable-versioned-macros/tests/trybuild.rs
+++ b/crates/stackable-versioned-macros/tests/trybuild.rs
@@ -21,9 +21,9 @@ mod inputs {
// mod attribute_enum;
// mod attribute_struct;
// mod basic_struct;
- // mod convert_with;
// mod deprecate_enum;
// mod deprecate_struct;
+ // mod downgrade_with;
// mod enum_data_simple;
// mod generics_defaults;
// mod generics_module;
sbernauer
requested changes
May 22, 2025
.../tests/snapshots/stackable_versioned_macros__snapshot_tests__k8s@conversion_tracking.rs.snap
Outdated
Show resolved
Hide resolved
sbernauer
reviewed
May 22, 2025
crates/stackable-versioned-macros/tests/inputs/k8s/pass/conversion_tracking.rs
Outdated
Show resolved
Hide resolved
sbernauer
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to downgrade CRDs.
#[versioned()]
macro generatesFrom
impls for downgrading.convert_with
parameter of thechanged()
action accordingly to support customizing both the upgrade and downgrade conversion function. There are now two separate parameters:upgrade_with
anddowngrade_with
.